InMemoryDatasets.jl icon indicating copy to clipboard operation
InMemoryDatasets.jl copied to clipboard

CompatHelper: bump compat for PrettyTables to 2, (keep existing compat)

Open github-actions[bot] opened this issue 3 years ago • 3 comments

This pull request changes the compat entry for the PrettyTables package from 0.12, 1 to 0.12, 1, 2. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

github-actions[bot] avatar Sep 08 '22 00:09 github-actions[bot]

Hi, Using your package a lot, can you update the compatibility with PrettyTable ? The commented row are still problematic with the input in PrettyTables function with doesn't have them anymore.

pretty_table(io, ds; alignment = alignment, alignment_anchor_fallback = :r, alignment_anchor_regex = alignment_anchor_regex, body_hlines = extrahlines, compact_printing = compact_printing, crop = crop, crop_num_lines_at_beginning = 2, ellipsis_line_skip = 3, formatters = pt_formatter, header = (names_str, names_format, types_str), header_alignment = :l, hlines = [:header], highlighters = (_PRETTY_TABLES_HIGHLIGHTER,), maximum_columns_width = maximum_columns_width, newline_at_end = false, # show_subheader = eltypes, # row_label_alignment = :r, # row_label_crayon = Crayon(), # row_label_column_title = string(rowlabel), # row_labels = row_names, row_number_alignment = :r, row_number_column_title = string(rowlabel), show_row_number = show_row_number, title = title, vcrop_mode = vcm, vlines = vlines, kwargs...)

MiletoCarmelo avatar Jun 08 '23 15:06 MiletoCarmelo

the problem is that if we allow older PrettyTable releases, some of its functionalities wouldn't work, i.e. newer versions of IMD will not work properly.

I guess your issue should be resolve in PrettyTable.

sl-solution avatar Jun 08 '23 17:06 sl-solution

the problem is that if we allow older PrettyTable releases, some of its functionalities wouldn't work, i.e. newer versions of IMD will not work properly.

I guess your issue should be resolve in PrettyTable.

Thank's for your fast reply!

MiletoCarmelo avatar Jun 08 '23 20:06 MiletoCarmelo