typed-scss-modules icon indicating copy to clipboard operation
typed-scss-modules copied to clipboard

Prettier isn't applied

Open remq opened this issue 1 year ago • 2 comments

Expected Behavior

After saving a scss file, typed-scss-modules is expected to apply Prettier.

Current Behavior

When upgrading my project to Prettier version from 3.1.0 to 3.1.1, typed-scss-modules didn't seem to apply Prettier after saving my scss files anymore.

Possible Solution

I haven't looked into it yet. Might do it at some point, but wanted to report it already. Reverting to Prettier 3.1.0 fixes it.

Steps to Reproduce (for bugs)

  1. Install Prettier 3.1.1
  2. Set any rule in the Prettier config that changes the expected output of typed-scss-modules
  3. Save a scss file

Context

N/A

Your Environment

  • Version used: 8.0.0
  • Prettier version used: 3.1.1

remq avatar Jan 04 '24 15:01 remq

Yes we just noticed the same issue on our project.

emondpph avatar Jan 05 '24 19:01 emondpph

Debugging and/or contributions are welcome.

skovy avatar Jan 15 '24 20:01 skovy

I will look at it over the weekend

Fouzyyyy avatar Mar 08 '24 09:03 Fouzyyyy

Hi everyone,

Here's a PR with a fix. 🤞

gmathieu avatar Mar 23 '24 02:03 gmathieu

:tada: This issue has been resolved in version 8.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Mar 23 '24 19:03 github-actions[bot]