Stavros Korokithakis

Results 521 comments of Stavros Korokithakis

Hmm, I'm not opposed to this, but why drop old versions? What does it achieve?

I agree in general, but would rather couple this with some breaking changes (ie drop support for old versions when we use new features). On one hand, if we don't...

Hmm, come to think of it, you're right, @gschaffner. We'd need to make these changes in the `setup.py`, but it sounds like that'd be OK.

Thanks for this! Yeah, 3.3 is ancient and wasn't very widely used, so I'd be in favor of dropping support for it. Would that make your PR easier/more elegant?

The difference is that `ignore_extra_keys` doesn't return the extra keys in the validated data.

Thank you for your contribution! Can you explain a bit more about why this is useful? I'm not getting the exact use case from the code :/

This is a great idea, agreed.

That's an interesting solution, although I'm not sure I like the API. My two thoughts are: * We might want to look into using type annotations rather than assigning a...

> the docstrings under the attributes is supported by sphinx to my knowlwedge. Very interesting, I didn't know that, thanks. > It depends on whether you want to be 2.7...

This sounds very good. I'm a bit worried that we're doing more API design than the medium of issues warrants, and that we're approaching other libraries' turf. In general, I...