skorch icon indicating copy to clipboard operation
skorch copied to clipboard

Callbacks: Generalize `yield_callbacks` into processing and output callbacks

Open githubnemo opened this issue 8 years ago • 1 comments

Currently, net._yield_callbacks discerns between PrintLog and other callbacks with the effect that PrintLog is added last to the list of callbacks so it has access to all processed values added by other callbacks. Maybe we should generalize this by classifying callbacks into two groups: processing callbacks and output callbacks.

Output callbacks (identified by inheriting from an abstract subclass of Callback) are by default appended to the end of the callback list. This would pave the way for other output callbacks besides PrintLog such as TensorBoard logging callbacks.

githubnemo avatar Sep 04 '17 22:09 githubnemo

Maybe PostponedCallback? PostAggregation?

ottonemo avatar Oct 02 '17 11:10 ottonemo