go.matrix icon indicating copy to clipboard operation
go.matrix copied to clipboard

matrix norms/determinant

Open kshedden opened this issue 12 years ago • 4 comments

I believe that the OneNorm and InfinityNorm functions are implemented incorrectly.

The OneNorm should be the sum of absolute values of the elements of the matrix.

The InfinityNorm should be the maximum absolute value of the elements of the matrix.

Also, it would be helpful to have a function that provides the log determinant, since the determinant will blow up for moderate or large matrix sizes.

kshedden avatar Jan 21 '13 05:01 kshedden

Oops, you're right, I switched those!

Feel free to make a pull request for LogDet()

On Mon, Jan 21, 2013 at 12:31 AM, kshedden [email protected] wrote:

I believe that the OneNorm and InfinityNorm functions are implemented incorrectly.

The OneNorm should be the sum of absolute values of the elements of the matrix.

The InfinityNorm should be the maximum absolute value of the elements of the matrix.

Also, it would be helpful to have a function that provides the log determinant, since the determinant will blow up for moderate or large matrix sizes.

— Reply to this email directly or view it on GitHubhttps://github.com/skelterjohn/go.matrix/issues/5.

skelterjohn avatar Jan 21 '13 11:01 skelterjohn

John,

Thanks, and thanks for your work on this project.

Best,

Kerby

On Mon, Jan 21, 2013 at 6:58 AM, John Asmuth [email protected]:

Oops, you're right, I switched those!

Feel free to make a pull request for LogDet()

On Mon, Jan 21, 2013 at 12:31 AM, kshedden [email protected] wrote:

I believe that the OneNorm and InfinityNorm functions are implemented incorrectly.

The OneNorm should be the sum of absolute values of the elements of the matrix.

The InfinityNorm should be the maximum absolute value of the elements of the matrix.

Also, it would be helpful to have a function that provides the log determinant, since the determinant will blow up for moderate or large matrix sizes.

— Reply to this email directly or view it on GitHub< https://github.com/skelterjohn/go.matrix/issues/5>.

— Reply to this email directly or view it on GitHubhttps://github.com/skelterjohn/go.matrix/issues/5#issuecomment-12494800.

kshedden avatar Jan 23 '13 01:01 kshedden

btw, the norm in this package uses vector norm not matrix norm.

taylorchu avatar Nov 29 '14 01:11 taylorchu

fixed in #15

taylorchu avatar Nov 29 '14 02:11 taylorchu