Jon Surrell
Jon Surrell
I'll continue using this PR to maintain context, but I'll rebase and push this forward incorporating ideas from #65708. Before making major changes the commit was d99f87c00c951ef72900fb09a0837568ead8b63a.
I think the way to handle packages that are included in WordPress Core (for licensing and for bundling) is by adding a field to their package JSON. Script modules have...
I think this is working correctly now and can be reviewed. I'm sure there will be changes to make to the workspaces setup, but all of the main pieces are...
This is building on https://github.com/WordPress/wordpress-develop/pull/7405.
See https://github.com/WordPress/gutenberg/pull/65539
This was reverted to avoid removing the public method. New PR with these changes: https://github.com/WordPress/wordpress-develop/pull/7447
@luisherranz @youknowriad @swissspidy @gziolo I'd love to have your review on this approach to allowing classic scripts to depend on script modules.
**Edit: removed** redacted @dmsnell My first thought was that this logic should be used to determine the parsing mode before calling Tag_Processor (parent) `step`: https://github.com/WordPress/wordpress-develop/blob/34c861b6a53cb82721ce0e82a3e2024d91c6ef7e/src/wp-includes/html-api/class-wp-html-processor.php#L873-L892 And _maybe_ the tag procuessor...
Thanks for the fixes here, I think this is good to go @dmsnell.
The fragment parser takes an Element. An HTML string seems like a poor representation for that 🙂 I wonder if the fragment parser could take a token (to create a...