sirpy

Results 129 comments of sirpy

@johnsmith-gooddollar i've added comments on the commits. please use PR next time

@L03TJ3 no, for all I recall the name is fetched only once for new txs. so the name will not update for older txs. it probably is also better this...

@decentralauren what do you mean? the default is public, if we enable to change, then the user should do it via the wallet privacy settings. but since the plan is...

was it working in the past on dev env? i think it only works on staging/production

@amark hmmm that's super strange, shouldnt effect unit tests at all yes we need the crypto shim, but we keep it as an external package the user has to install,...

@amark i dont know why it runs two different travis builds, /push and /pr i've looked at other PRs and it only runs /pr which passes also here

@decentralauren probably under the wrong repo (GoodServer)

@L03TJ3 you are probably right. @decentralauren What products would this be relevant to