app

app copied to clipboard

This MR try to address the following this feature request https://github.com/simple-login/app/discussions/469

The JavaScript part may be a bit tricky, but I tried to adapt in order to keep the already existing package (here the multi-select one). I think the consistency might be better in terms of UI.

If you find a cleaner way, feel free to drop a comment.

Thanks for making the PR. It seems that all aliases have the same websites as you can see in the below screenshot:

And we have a display error when there's no websites used:

I've thought again about the feature request and am wondering maybe this isn't relevant any more because: a) now that in the browser extension we automatically add "Used on website.com", we can know easily where an alias is created b) The AliasUsedOn is used to inform users that an alias has been created on a website before but I don't see the utility of this.

I think what we can do instead is to

• update the alias note to something like "Created on website1, website2, etc" based on AliasUsedOn data for old aliases that were created before "Used on website.com" was added
• remove the AliasUsedOn table

What do you think?

Concerning the display issue, it should use the multipleSelect like the select for the mailboxes

Let me know if it is still not there after refreshing the page, reinstalling the npm packages or if you have errors in the browser console, maybe.

Concerning the usefullness of the AliasUsedOn, I personaly don't use the SL extension in my daily usage, but I think, the AliasUsedOn is used for the extension in order to autocomplete the email field by one of the aliases used for this website.