Simon Walz

Results 11 comments of Simon Walz

Hi Thank you for participating in this project. I am not sure that I understand your problem. Could you please describe the actual problem? As far as I can remember,...

Hi Nice initiative! Are you adding a Github Workflow to create the debian package or what is your plan? Would you consider adding a check with shellcheck as a prerequisite?...

I agree with the separate PR for shellcheck. I created #15. I will research (and maybe try) if it makes sense to build Debian packages in Github workflows.

It looks like it works with Github workflows. See https://github.com/simonwalz/screen-save/releases/tag/v1.2.6 I don't have much experience with deb packages. Is the deb package OK for you?

I have seen your progress and I like the idea with the systemd units and timer. I would suggest, that we create one systemd unit/timer, that does the following: *...

Hi Thanks for your suggestions. I have already taken a look at your PR, and I like it. After your modification the script can only be run by the root...

Ohhh, now I get your idea. On my Debian box my user can read his screen session files in `/var/run/screen`. But when running `su - "${USER}" -c ...` the process...

```sh eval "${command}" ``` is not a secure. ```sh su - "${screen_user}" -c "${command}" ``` as well. Better use: ```sh "${SCRIPTDIR}/screen-save" "arg1" "arg2" ... su - "${screen_user}" -c "${SCRIPTDIR}/screen-save" "arg1"...

Do you want to try the suggestion from https://github.com/simonwalz/screen-save/issues/20#issuecomment-2322900980 or shall I adapt and merge https://github.com/simonwalz/screen-save/pull/13 ?

A note for later discussion: For this vision we don't need much - but some aspects still need to be investigated, for example: * What happens during updates? The systemd...