Simon Proud

Results 127 comments of Simon Proud

Ok, I updated the names - hopefully the new one is better suited!

> Should probably rename `test_mersi2_l1b.py` to `test_mersi_l1b.py` to match the reader python module, right? > > And is this ready to be marked as "Ready for Review"? Ooops, yes to...

Interesting, how are you retrieving those files? Are they from direct broadcast or the CMA datacentre? All of mine are from CMA - so if yours are DB then maybe...

i've now updated the HNCC composite to cope with missing Moon phase data, it should calculate it internally. Tests are also updated to test as much of this as I...

Codefactor isn't happy, but those appear to be existing problems rather than something new.

Forgot about this, will take a look in the next few days.

@mraspaud Hopefully the extra test I just added will address the issue raised by @djhoese

Just had a quick look through the code, all looks good to me!

On your second point, I think that if both L1 and L2 dataset files are provided by the user them the higher level dataset should be used by default.