Signal-Android icon indicating copy to clipboard operation
Signal-Android copied to clipboard

Image is flipped compare to video

Open jesperpedersen opened this issue 1 year ago • 6 comments

  • [x] I have searched open and closed issues for duplicates
  • [x] I am submitting a bug report for existing functionality that does not work as intended
  • [x] I have read https://github.com/signalapp/Signal-Android/wiki/Submitting-useful-bug-reports
  • [x] This isn't a feature request or a discussion topic

Bug description

If you take a picture is "orientation" is incorrect - it is flipped, so left becomes right, and visa-versa.

However, if you make a video call, or file, it is correct.

Steps to reproduce

  • Take a picture
  • Take a video
  • Compare the "orientation"

Actual result:

  • Flipped image

Expected result:

  • Pictures is the same orientation as taking a video

Device info

Device: Samsung S9 Android version: 10 Signal version: 7.5.2

jesperpedersen avatar Apr 25 '24 16:04 jesperpedersen

It seems to depend on the orientation of the phone... Horizontal, vertical and so on

jesperpedersen avatar Apr 29 '24 17:04 jesperpedersen

So this seems to be particularly for selfie pictures. (Pictures taken with the back camera are always correct)

When Signal takes a selfie picture, both the preview and the final image are mirrored left-to-right (meaning that text in the image is unreadable).

However, when Signal takes a selfie video, the preview is mirrored left-to-right, but the resulting video is not mirrored.

Preview Resulting file
Photo Mirrored Mirrored
Video Mirrored Not Mirrored

These are the same results as I get for my default camera app on a Zenfone 9.

mbartlett21 avatar May 01 '24 23:05 mbartlett21

These are the same results as I get for my default camera app on a Zenfone 9.

I suppose some people want the same result as the preview… On the Pixel Photo app, there is a setting exactly for that. I don’t know whether it is the default, but it is disabled on my Pixel 8. (Worst is, Google Photo does not even have a feature to flip pictures, so you can’t easily flip the pictures once taken!)

~So if the default is changed (and I think it should probably be), it might be nice to have a feature to flip the pictures in the editing tools for people who don’t like that (but I think most people who take flipped pictures just don’t care).~ This already exists.

DidierLoiseau avatar May 25 '24 11:05 DidierLoiseau

This, unfortunately, appears to be a device-specific bug. We rely on Google's camera compatibility library which promises to "provide a number of compatibility fixes and workarounds to help make the developer experience consistent across many devices", so hopefully this will be fixed by Google in an upcoming library release.

nicholas-signal avatar Jul 16 '24 21:07 nicholas-signal

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 15 '24 01:09 stale[bot]