nuxt-auth icon indicating copy to clipboard operation
nuxt-auth copied to clipboard

Published 20 hours ago • verified publisher icon sidebase

addDefaultCallback can be set with refresh and local providers

Open nojiritakeshi opened this issue 1 year ago • 2 comments

🔗 Linked issue

https://github.com/sidebase/nuxt-auth/issues/622 https://github.com/sidebase/nuxt-auth/issues/656

❓ Type of change

  • [ ] 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • [x] 🐞 Bug fix (a non-breaking change that fixes an issue)
  • [ ] 👌 Enhancement (improving an existing functionality like performance)
  • [x] ✨ New feature (a non-breaking change that adds functionality)
  • [ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

addDefaultCallback can now be set by refresh and local provider. I have confirmed that it works in playground.

📝 Checklist

  • [x] I have linked an issue or discussion.
  • [ ] I have added tests (if possible).
  • [ ] I have updated the documentation accordingly.

nojiritakeshi avatar Mar 10 '24 10:03 nojiritakeshi

Hi @nojiritakeshi 👋

Thank you for your contribution, and I apologize for the delay! As this change is very straight forward and reuses logic from the AuthJS provider, I think we can quickly push this through and release it in 0.8.0!

Could you please fix the merge conflicts and then we can do a review and hopefully merge without any issues 😊

zoey-kaiser avatar May 09 '24 10:05 zoey-kaiser

Hi @zoey-kaiser ! Thanks for the review. Conflicts have been resolved, please check again.

nojiritakeshi avatar May 11 '24 04:05 nojiritakeshi

Hi @zoey-kaiser 😄

Indeed. I agree with that opinion. I may take some time since I've been busy lately, but I'll try to find the time to fix it.

nojiritakeshi avatar May 22 '24 09:05 nojiritakeshi

Hi @zoey-kaiser . This modification is made so that the string set in the addDefaultCallback property in nuxt.config is applied to the callbackUrl.

There we allow you to set addDefaultCallbackUrl to a boolean to enable / disable automatic callback URL detection or hard code it to a string, which is then always the callback URL?

Therefore, I do not see the need to make a new correction to this point, do you?

Please let me know if I am misguided!

nojiritakeshi avatar Jun 15 '24 12:06 nojiritakeshi

This modification is made so that the string set in the addDefaultCallback property in nuxt.config is applied to the callbackUrl.

You are right! I revised this PR and agree! Sorry about the confusion! Thank you for your contribution! I will release this PR in 0.8.0-rc.1 now! 🥳

zoey-kaiser avatar Jun 28 '24 06:06 zoey-kaiser