Siddhartha Bagaria

Results 65 comments of Siddhartha Bagaria

I did not do any performance regression testing. But some performance hit may be expected. Go toolchain is now running a small linker command before running the actual link command....

Which hermetic toolchain do you use in your CI? Maybe I can help with this investigation if I find time.

It is also very likely that you would hit the increased build time issue when you move to Go 1.21, which has a similar change as in this PR, but...

I tried to reproduce with `bazel build --incompatible_enable_cc_toolchain_resolution --extra_toolchains @zig_sdk//toolchain:linux_amd64_gnu.2.34 --remote_cache= --disk_cache= //tests/core/cgo:c_srcs` and the updated toolchain you posted above. I can not reproduce what you are describing; maybe I...

Closing this because it has been roughly a year since the release of Go 1.21, so it is less needed now. The extra diligence for regression testing makes it not...

Thanks! Handling just the case of StirredTankReactor seems straightforward. I may visit this if I find more time in the coming weeks.

I also looked at this more after creating the issue and thought that this is going to be non-trivial and span multiple projects. I also don't see any interest from...

Can we please get this merged? The `future` package is not very well maintained now, and can not build with Python 3.11 with the `PYTHONSAFEPATH` env var set. We can...

tests/MODULE.bazel is now present in the dashboard.

Interesting! Thanks. If you have the time to do it, you can add this as an additional source of URLs in this repo for auto detection. Note that users can...