Clément Vannicatte

Results 149 comments of Clément Vannicatte

Thanks! This is being worked on for Java and JavaScript here: https://github.com/algolia/api-clients-automation/pull/829

> Should the hit be overridden by the generic ? It should be `type Hits = Array` and `type Hit = T & { ...baseProps }`

Not for now as we have other priorities, but if you have an implementation in mind feel free to contribute!

> thanks for the contribution! I actually had a local branch for this feature, I'll add them to your branch and push so we can discuss it :) had trouble...

Hey, thanks for reporting the bug, we've added it to our backlog and will come back to it ASAP. You can still use the `Docusaurus v2` template for `Docusaurus v3`,...

Same comments as in the issue for me too, the UA is the whole string being sent, `Algolia for JavaScript` is not scoped to the search client, the following segment...

And also, this is common to every clients, see https://github.com/algolia/api-clients-automation/blob/main/tests/output/python/tests/client/monitoring_test.py#L27 or https://github.com/algolia/api-clients-automation/blob/main/tests/output/java/src/test/java/com/algolia/client/QuerySuggestions.test.java#L52 and so on

> The `createUserAgent` function shouldn't set "Algolia for JavaScript" by default. Instead, this agent should be added in the build of the Search client. IMHO this segment can stay because...

All! It's clearer in the next major version as all clients can be used as standalone but it's mostly to identify the language associated to the API client for usage...

Hey, thanks for opening the issue. https://github.com/algolia/docsearch/issues/1823 seems related. I'll investigate if there's a way for us to differentiate hash routed pages from anchored sections