Andrew Powell

Results 620 comments of Andrew Powell

@glasser just ran into this today. what needs to be done to get this change merged? I'll pick up the effort tomorrow to make it happen.

I'm a bit confused. I don't see any mention of `serverless-express` here https://github.com/apollographql/apollo-server/blob/388e650f211e0046d715ed22f27a1dc833e1ceb3/packages/apollo-server-lambda/src/ApolloServer.ts#L1 wrt to the `Handler` type. Are you saying you'd prefer that this package didn't maintain that type,...

@benjie some additional curious behavior that I can't find documentation around: ```ts makeExtendSchemaPlugin({ typeDefs: gql` type Foo { bar: Boolean } ` }); ``` ```ts builder.hook('GraphQLObjectType', (field, _, context) =>...

Thanks for the explanation. I think there's enough there to close this one as explained.

Understood. What's the method to get that serverside directive added to `scope.directives` for `Query` if not with makeExtendSchemaPlugin?

OK thanks, that gives me an idea about how to accomplish the goal. I can see what you mean about plugin ordering, that will be tricky. You're welcome to close...

Merging typeDefs seems like a possibility: ```ts import { inspect } from 'util'; import { mergeTypeDefs } from '@graphql-tools/merge'; const result = mergeTypeDefs([`type Query`, `type Query @deprecated`]); console.log(inspect(result, { depth:...

The dreaded smart comment newline issue strikes again. Shortly after opening this, I realized that there was a newline in another related smart comment `COMMENT ON` and that was nuking...

Point me in the right direction and I'll give it a go. I've not worked with the repo source before so that would be helpful. (I'm unable to find that...