minigalaxy icon indicating copy to clipboard operation
minigalaxy copied to clipboard

Erases all of the installers when downloading new ones.

Open ShockedCoder opened this issue 3 years ago • 4 comments

When Mini begins to download an update or a DLC it deletes the existing installers that are related to the game.

ShockedCoder avatar Aug 01 '22 14:08 ShockedCoder

Thanks for reporting this, that's a pretty bad bug. I'll look into it.

sharkwouter avatar Sep 05 '22 13:09 sharkwouter

I get that programming is a hard job, but how difficult is it to remove the instruction to remove files?

Sorry, if I sound like a snobby cunt.

ShockedCoder avatar Oct 07 '22 18:10 ShockedCoder

I'm doing this in my free time, so I just work on it when it reaches the top of my list of things I want to work on. I would welcome a PR which solves this issue, though.

What makes this one a little bit harder to solve is that the install function only knows of 1 of the installer file and there can be multiple. Before it was deleting only one, now it is deleting too many files. I'll have to look at Innoextract's code to figure out what kind of names the files might have and then use a regular expression for it, write some tests and then pray there is not some edge case which causes a new bug.

sharkwouter avatar Oct 10 '22 08:10 sharkwouter

Dam bro, my bad. Sadly, I can't do a PR, since I don't know how to code, but best of luck. my bad, man.

ShockedCoder avatar Oct 10 '22 08:10 ShockedCoder