quakespasm Glistening effect on distant water

Glistening effect on distant water

Open Flecked42 opened this issue 3 years ago • 8 comments

https://user-images.githubusercontent.com/90434262/189554968-4ea798e3-b54b-4e45-a08f-6fe6a0345987.mp4

Happens with both r_oldwater 0 and 1

For reference this doesn't happen in Ironwail or vkQuake.

Sep 11 '22 23:09 Flecked42

I assume this happens with version 0.95.0, but not with 0.94.7?

@ericwa, @andrei-drexler: ideas?

Sep 12 '22 00:09 sezero

It happens with both 0.95.0 and 0.94.7.

Btw the map is sm221_hcm from https://www.quaddicted.com/filebase/sm221-bridges-v1.1.zip

Sep 12 '22 00:09 Flecked42

When r_oldwater is 0, I would guess this is aliasing due to not having mipmaps on the warp image?

Could try https://www.khronos.org/opengl/wiki/Common_Mistakes#Legacy_Generation

Sep 12 '22 01:09 ericwa

Yeah, your tip fixed it Eric, thx a lot ❤

Sep 12 '22 20:09 j0zzz

Can someone send a patch for QS git?

Sep 12 '22 20:09 sezero

https://github.com/j0zzz/JoeQuake/commit/0527dd9dac8b1f4904be2e37771a21849083edd8 is the commit that fixed it in JoeQuake.

Sep 12 '22 21:09 Flecked42

I tried adding it to QS but enabling TEXPREF_MIPMAP on the warp image makes it crash, so I would let someone else with much wider knowledge do it.

Sep 12 '22 21:09 j0zzz

You need to actually generate mipmaps after rendering the warp image to fix this

Sep 13 '22 07:09 Novum

Fixed by PR #44. Closing the ticket.

Nov 03 '22 03:11 sezero