heatmap icon indicating copy to clipboard operation
heatmap copied to clipboard
verified publisher icon sethoscope

Tests for #53

Open bvacaliuc opened this issue 7 years ago • 2 comments

As requested, added tests for PR for #53

bvacaliuc avatar Jun 29 '18 03:06 bvacaliuc

Coverage Status

Coverage increased (+0.4%) to 79.609% when pulling c756cfe558ae015bc9a7ad317a27ee8e0f2910b6 on bvacaliuc:tests_53 into ca130282fbba552cc09def881783b3a5acc31768 on sethoscope:master.

coveralls avatar Jun 29 '18 04:06 coveralls

Hi, Bogdan. Thanks for adding the weight handling. Bonus points for writing a test case! I notice the test data contains 2590 points. It seems like you could test this well with just three points (one negative, one small, one large), and it would be much easier to understand. As it is, I can't tell whether the test would fail if weights were ignored.

Any interest in trying that? If not, I can aim to get to it eventually.

sethoscope avatar Jul 04 '18 04:07 sethoscope