serverless-google-cloudfunctions icon indicating copy to clipboard operation
serverless-google-cloudfunctions copied to clipboard

Published 20 hours ago • verified publisher icon serverless

feat: Adding support for failure policy

Open patrickhousley opened this issue 7 years ago • 11 comments

This PR adds support for setting eventTrigger failurePolicy on individual functions.

patrickhousley avatar Nov 02 '18 14:11 patrickhousley

Related to #131

zdraganov avatar Jan 04 '19 13:01 zdraganov

@patrickhousley it's good to add something into the README when you are extending current code

zdraganov avatar Jan 04 '19 13:01 zdraganov

@patrickhousley ^

patrickbrandt avatar Jan 05 '19 22:01 patrickbrandt

Sorry fellows, been on vacation. So I would normally agree if the README was actually used for documentation. However, it is not in this repo. I will leave it to the repo maintainers to decide how best to document this change.

patrickhousley avatar Jan 06 '19 22:01 patrickhousley

Is this going to be merged? If not, please close it and explain why.

patrickhousley avatar May 03 '19 22:05 patrickhousley

LGTM?

teddy-codes avatar Aug 09 '19 03:08 teddy-codes

can merge this PR? really need it ~

hjaurum avatar Nov 04 '19 08:11 hjaurum

is anyone gonna merge this PR? @pmuens

buffolander avatar Dec 08 '19 23:12 buffolander

Is there a plan to merge this PR? It would be helpful.

gretro avatar Jan 07 '20 02:01 gretro

Is this PR still active? The changes would be extremely useful

paulohpigatto avatar Apr 06 '20 19:04 paulohpigatto

@patrickhousley Thanks for the PR! Just pinging in case you didn't notice the tests failed. It seems easy to fix and perhaps we can ping the other collaborators after tests pass to get this merged.

frandiox avatar Jun 05 '20 12:06 frandiox