serialport-rs icon indicating copy to clipboard operation
serialport-rs copied to clipboard

Published 20 hours ago • verified publisher icon serialport

Update dev-dependecy clap to v4.0

Open g0hl1n opened this issue 2 years ago • 2 comments

This PR updates clap dependency to its latest version (3.1.6 => 4.0).

The clap update needed some changes in the code because of function deprecation in the clap v3.2.0 and clap v4.0.0 releases.

This PR is a follow-up of https://github.com/serialport/serialport-rs/pull/72.

MSRV

Furthermore bump the MSRV to 1.60.0 as this is required by clap v4.0.0 (see https://github.com/clap-rs/clap/pull/4060). https://github.com/serialport/serialport-rs/commit/0a743546848cffd27da9851aea98980b18f05b95 reduced the MSRV because of a Yocto dependency. Currently following rust versions are used in the maintained yocto project versions:

Therefore this MSRV change (1.46.0 => 1.60.0) will drop kirkstone support, which is the current LTS release, supported until April 2024 at least (according to https://wiki.yoctoproject.org/wiki/Releases).

g0hl1n avatar Dec 18 '22 20:12 g0hl1n

Thanks for this. For the time being I think we should continue to support kirkstone, so I'm not too keen on bumping the MSRV just yet.

jessebraham avatar Dec 21 '22 16:12 jessebraham

Ok. So I'll keep this open and updated so we can mere it whenever it fits.

Do you have any "next major release" label or 5.0 milestone where we can "attach" this?

g0hl1n avatar Dec 25 '22 13:12 g0hl1n