reGeorg icon indicating copy to clipboard operation
reGeorg copied to clipboard

Wrong way to parse Socks5 protocol

Open EddieIvan01 opened this issue 5 years ago • 1 comments

In parseSocks5 function:

nmethods, methods = (sock.recv(1), sock.recv(1))

The methods field's length is variable. In some socks5 client, an error will be throwed. Such as curl #9

Should write like this:

nmethods = sock.recv(1)
sock.recv(ord(nmethods))

It seems like no one has been maintaining this repo for a long time, I think my pr will not be handled. So if anyone is going to rewrite this repo, remember to fix it

EddieIvan01 avatar Mar 21 '20 11:03 EddieIvan01

Thanks for reminding, Neo-reGeorg fixes the problem

L-codes avatar Oct 09 '20 05:10 L-codes