semaphore

semaphore copied to clipboard

I ran into an issue when I deployed with my ldap credentials. My SEMAPHORE_LDAP_DN_BIND has a space in it. fmt.Scan stops at spaces, so the values got cut up and distributed incorrectly. The change proposed creates a single reader for all cases of ingesting user input (instead of a half mix of bufio.Reader and fmt.Scan).

Compilation and tests pass on my end. I also provided my config with the spaces in it and works.

Hi @jamesalbert Thank you! Will test soon.

Hey @fiftin sounds good!

Hi @jamesalbert could you merge develop again to trigger GitHub Actions for tests?

hey @fiftin (long time to talk to! 😅 ), I didn't have the option to merge develop again, but I triggered the action by adding a clearer comment in askValue.