seminr icon indicating copy to clipboard operation
seminr copied to clipboard

missing # character in csem2seminr.Rd example

Open yrosseel opened this issue 2 years ago • 7 comments

In man/csem2seminr.Rd line 20, there is missing comment character ('#') just before 'Composite model'.

The old parser in lavaan simply ignores this line (with a warning), but the new parser in the next update of lavaan is not so forgiving. Could you please fix this and submit to CRAN?

yrosseel avatar Oct 20 '23 07:10 yrosseel

Thanks for the catch @yrosseel ! I'll get on it. Can I ask if it would be ok for us to wait a bit to push the fix out as part of a larger update? Does this affect your upcoming efforts or create annoying check warnings for you? I'm asking as CRAN does not seem to like too frequent updates (and I had some other things in mind to fix).

soumyaray avatar Oct 21 '23 13:10 soumyaray

No problem. We discovered similar syntax issues in several packages (thanks to the new parser), and they all need time to adapt. In the next update of lavaan (0.6-17, hopefully ready in a few weeks), the old parser will still be the default. But in 0.6-18 (to be released somewhere early next year, I hope), I would prefer to use the "new" parser per default.

yrosseel avatar Oct 21 '23 16:10 yrosseel

excellent job on lavaan! we'll catch up.

soumyaray avatar Oct 21 '23 16:10 soumyaray

I would like to release of lavaan 0.6-18 (with the new parser) soon. Any ideas when the current version of seminr goes to CRAN?

yrosseel avatar May 01 '24 15:05 yrosseel

We will get a patch out in coming days – please proceed with lavaan's release as planned! I'll close the issue once our patch is accepted.

soumyaray avatar May 05 '24 13:05 soumyaray

I see the issue is still not fixed on github. I really prefer that this is fixed on CRAN before I upload lavaan. Any idea about the timeline?

yrosseel avatar Jun 02 '24 17:06 yrosseel

Dear @yrosseel – I'll talk to the maintainer @NicholasDanks today and get it out asap.

soumyaray avatar Jun 05 '24 00:06 soumyaray