PcapPlusPlus icon indicating copy to clipboard operation
PcapPlusPlus copied to clipboard

Add memory sanitizer regressions check

Open sashashura opened this issue 3 years ago • 2 comments

Just checking some things...

sashashura avatar Aug 01 '22 17:08 sashashura

nope

sashashura avatar Aug 01 '22 17:08 sashashura

@sashashura just FYI - you can keep the PR open as "draft" if you want to test things. You don't have to close and reopen it :)

seladb avatar Aug 01 '22 19:08 seladb

@sashashura is this PR ready for review?

seladb avatar Aug 17 '22 08:08 seladb

Depends... I was able to make it work with the gcr.io/oss-fuzz-base/base-clang docker image. It is not ideal because it is not the same image that is used in other regression test tasks.

sashashura avatar Aug 18 '22 05:08 sashashura

Depends... I was able to make it work with the gcr.io/oss-fuzz-base/base-clang docker image. It is not ideal because it is not the same image that is used in other regression test tasks.

I wonder what is different between gcr.io/oss-fuzz-base/base-clang and the image we use for the other tests seladb/ubuntu1804. Maybe Ubuntu 18.04 is too old and we should use seladb/ubuntu2204? 🤔

seladb avatar Aug 18 '22 09:08 seladb

I narrowed it down to https://github.com/google/oss-fuzz/blob/master/infra/base-images/base-clang/checkout_build_install_llvm.sh. It must be about building custom libcxx as described in https://github.com/google/sanitizers/wiki/MemorySanitizerLibcxxHowTo

sashashura avatar Aug 19 '22 07:08 sashashura

I narrowed it down to https://github.com/google/oss-fuzz/blob/master/infra/base-images/base-clang/checkout_build_install_llvm.sh. It must be about building custom libcxx as described in https://github.com/google/sanitizers/wiki/MemorySanitizerLibcxxHowTo

Got it, that makes in a way... It's interesting that the other sanitizers (Address and Undefined Behavior) don't need a custom libcxx build. What's also interesting is that it passes although libpcap is not MSan-ified. If it works I guess we can use the oss-fuzz image, what do you think?

seladb avatar Aug 20 '22 08:08 seladb

Yes, let's use the image.

sashashura avatar Aug 21 '22 11:08 sashashura