kafka-go icon indicating copy to clipboard operation
kafka-go copied to clipboard

PartitionEoF error in the reader

Open glossd opened this issue 1 year ago • 4 comments

This PR enables Reader to notify the user when it reaches the end. This is the same functionality as in librdkafka with config enable.partition.eof

glossd avatar Jan 20 '24 23:01 glossd

The tests are failing with the Request Timed Out, my local tests were failing like that too. However, it seems that my added test passes. Any advice?

glossd avatar Jan 20 '24 23:01 glossd

@petedannemann Hi, I fixed the tests, but some of them are failing from time to time due to Request Timed Out error. I believe this is the issue Flaky tests . Could you please review?

glossd avatar Jan 26 '24 12:01 glossd

@petedannemann @ssingudasu Hello, could you please review this PR? I need this functionality for my project, and unlike sarama and confluent, this library doesn't have it. Or at least let me know if you're not going to review this.

glossd avatar Feb 09 '24 09:02 glossd

@petedannemann @ssingudasu Hello, could you please review this PR? I need this functionality for my project, and unlike sarama and confluent, this library doesn't have it. Or at least let me know if you're not going to review this.

Just fork the repo for now to unblock yourself. We have a very lean team with limited capacity and cannot spend much time at our jobs reviewing open source contributions from outside contributors. We will get to this when we can find time for it

petedannemann avatar Feb 09 '24 14:02 petedannemann