FlaPy icon indicating copy to clipboard operation
FlaPy copied to clipboard

End-to-end test doesn't work with docker => Replace "-it" flag in docker run

Open gruberma opened this issue 2 years ago • 1 comments

I use the "-it" flags, when running flapy.sh run locally, so that the user can kill the process using Ctrl-C: https://github.com/se2p/FlaPy/blob/master/run_line.sh#L86

However, this causes the end-to-end test to fail with the input device is not a TTY when using docker. For podman it works fine.

=> Remove the "-it" flag, but add some mechanism to make the process killable via Ctr-C

gruberma avatar Feb 23 '23 10:02 gruberma

Probably you could just start the container without the "-it" option. Then you have to adjust the docker run command with "docker run --name 'my_custom_name'" to reference the container after you've started it. With "docker exec 'my_custom_name'" you should be able to hop into the container just like in interactive mode, right?

This removes the -it option which causes the TTY error, but nevertheless, you can use the container in interactive mode.

FabianScharnboeck avatar Mar 13 '23 07:03 FabianScharnboeck