page-transitions-travelapp icon indicating copy to clipboard operation
page-transitions-travelapp copied to clipboard

Published 20 hours ago • verified publisher icon sdras

A sticky footer could make thing even smoother

Open sheriffderek opened this issue 6 years ago • 3 comments

At certain screen sizes - the footer kinda jumps around - and gives it just a little less polished feeling that it could have. (Really great job on these transitions!) https://philipwalton.github.io/solved-by-flexbox/demos/sticky-footer/

sheriffderek avatar Jul 31 '19 17:07 sheriffderek

I hadn't noticed that! Probably just browsing too short of a window. Will fix! PRs also accepted.

sdras avatar Oct 30 '19 20:10 sdras

I'm not sure how the <main> animation conditional works - so, it might need a parent. You could use a custom element like <main-outlet> or something (ensure it's block level) - and then add the flex-grow to that... otherwise, it switches out the whole main element. Just using the browser tools - it would be like this:

Screen_Shot_2019-10-30_at_3_03_07_PM

perpetual-education-personal avatar Oct 30 '19 22:10 perpetual-education-personal

I know how sticky footers work :) if you want to PR, please do. Otherwise I'll handle it.

sdras avatar Oct 30 '19 22:10 sdras