quicktill icon indicating copy to clipboard operation
quicktill copied to clipboard

Published 20 hours ago • verified publisher icon sde1000

Consider removing current_user().dbuser

Open sde1000 opened this issue 4 years ago • 1 comments

The dbuser attribute of current_user() will often be a detached ORM instance. It's currently refreshed in an ad-hoc way.

Consider removing this attribute and updating the rest of the code to use the userid attribute instead, getting a User object via the current database session every time it is needed.

sde1000 avatar Oct 18 '21 12:10 sde1000

(Prompted by 8f60116f941db26a5b91b06ec9eb4079f20194e5 which shouldn't have had to be fixed that way!)

sde1000 avatar Oct 18 '21 12:10 sde1000