SafeTrace icon indicating copy to clipboard operation
SafeTrace copied to clipboard

Published 20 hours ago • verified publisher icon scrtlabs

UI updates & parse script

Open alaaltoros opened this issue 5 years ago • 10 comments

PR related to issue #21 (Front-End UI for MVP)

It includes the following:

Basic UI Login/logout with google Location data parse script I Will be updating it as soon as other parts are ready.

P.S. The login/logout functionality requires google client id (check the README.md) and the upload button will output the parsed data in the console.

alaaltoros avatar Apr 06 '20 15:04 alaaltoros

Hey @alaaltoros can you add a description to this PR explaining what it is?

ainsleys avatar Apr 06 '20 16:04 ainsleys

PR related to issue #21 (Front-End UI for MVP)

It includes the following:

  • Basic UI
  • Login/logout with google
  • Location data parse script

I Will be updating it as soon as other parts are ready.

P.S. The login/logout functionality requires google client id (check the README.md) and the upload button will output the parsed data in the console.

alaaltoros avatar Apr 06 '20 17:04 alaaltoros

Added report and file upload basic functionality

alaaltoros avatar Apr 08 '20 14:04 alaaltoros

Hello @lacabra, I updated the README.md file and the directory structure. Let me know if you can get the client to run or if you have any other comments or doubts. Please note that the backend is included in a different repository and a different pull request (I added a URL in the README.md file)

alaaltoros avatar Apr 09 '20 14:04 alaaltoros

Added the Results page with formatted data. However, I could not test with a real response from findMatches endpoint of Enclave; I received no matches and could not upload report new results because of the CORS error.

alaaltoros avatar Apr 13 '20 16:04 alaaltoros

@alaaltoros I have tested your last changes and in general, it looks good. Regarding the issue that returns CORS error, I have done some tests and I see that the problem occurs when there are 2 consecutive calls to the Enclave endpoints. If I execute one only it works. I think the problem is related to the promise or await functions.

cmalfesi avatar Apr 15 '20 00:04 cmalfesi

@alaaltoros I have an improvement for the frontend to get better behavior with consecutive calls to the enclave endpoints. We need to separate addPersonalData and findMatch in different async functions. This solves the CORS problem. I'll send you the required changes.

cmalfesi avatar Apr 15 '20 11:04 cmalfesi

@alaaltoros can you resolve the conflicts? Also waiting for @cmalfesi CORS fixes in order to merge this.

assafmo avatar Apr 20 '20 08:04 assafmo

@assafmo conflicts resolved!

alaaltoros avatar Apr 20 '20 12:04 alaaltoros

Still seeing conflicts in UIcode/client/package-lock.json and UIcode/client/yarn.lock. You can remove the one you don't use and rebuild the one you use.

assafmo avatar Apr 20 '20 14:04 assafmo