mongodb-container icon indicating copy to clipboard operation
mongodb-container copied to clipboard

Timezone for container - petset

Open git001 opened this issue 8 years ago • 19 comments

The default timezone is utc. Some customers need to have there local timezone. It would be nice to be able to set the timezone at the creation time

git001 avatar Jan 24 '17 11:01 git001

Can one of the admins verify this patch?

openshift-bot avatar Jan 24 '17 11:01 openshift-bot

Can one of the admins verify this patch?

centos-ci avatar Jan 24 '17 11:01 centos-ci

Can one of the admins verify this patch?

rhscl-bot avatar Jan 24 '17 11:01 rhscl-bot

Can one of the admins verify this patch?

centos-ci avatar Feb 07 '17 12:02 centos-ci

Can one of the admins verify this patch?

rhscl-bot avatar Feb 16 '17 12:02 rhscl-bot

[test][test-openshift]

omron93 avatar Mar 03 '17 10:03 omron93

There is missing setting TZ variable inside container. @git001 Please add.

                   {
                    "name": "TZ",
                    "value": "${TIMEZONE}"
                   }

omron93 avatar Mar 21 '17 09:03 omron93

done

git001 avatar Mar 23 '17 15:03 git001

Thanks for your contribution.

@git001 I hope last two things, please rebase to latest master (now PR can't be merged) and and empty line before TIMEZONE variable in mongodb-petset-persistent.yaml . Thanks, I'll merge it then.

[test][test-openshift]

omron93 avatar Mar 24 '17 06:03 omron93

ping

goern avatar Apr 20 '17 14:04 goern

sorry but again I fail on git handling.

I always edit over the GUI and when the PR is commented I never come to a good result with the git commands.

Isn't is possible to use squashed merge? https://help.github.com/articles/about-pull-request-merges/#squash-and-merge-your-pull-request-commits

I thin due to the limitation of the GUI I will stop to contribute, just because it makes me so much headache to make it in the right way.

If the squash-and-merge way is not possible then just throw the PR.

git001 avatar Apr 20 '17 21:04 git001

@git001 It is possible to use "squash merge". But this won't solve file conflicts (so it is not possible).

I thin due to the limitation of the GUI I will stop to contribute, just because it makes me so much headache to make it in the right way.

With command line it can be done:

  1. Add upstream remote - https://help.github.com/articles/configuring-a-remote-for-a-fork/
  2. git checkout <your branch> and git rebase upstream/master
  3. In file examples/petset/mongodb-petset-persistent.yaml is conflict, so automatic rebase is not possible (git rebase command will tell). So manual edit of conflict file is required (to contain both - your and upstream changes), then git add <updated conflict file> and git rebase --continue.
  4. Force push to PR branch.

Or should I create a new PR?

omron93 avatar Apr 25 '17 10:04 omron93

Can one of the admins verify this patch?

rhscl-bot avatar Nov 28 '17 15:11 rhscl-bot

Can one of the admins verify this patch?

centos-ci avatar Nov 28 '17 15:11 centos-ci

Can one of the admins verify this patch?

rhscl-bot avatar Feb 17 '18 10:02 rhscl-bot

Can one of the admins verify this patch?

rhscl-bot avatar Feb 11 '19 20:02 rhscl-bot

Can one of the admins verify this patch?

rhscl-bot avatar Mar 09 '19 14:03 rhscl-bot

Can one of the admins verify this patch?

rhscl-bot avatar Jul 19 '19 08:07 rhscl-bot

Can one of the admins verify this patch?

rhscl-automation avatar Sep 03 '20 08:09 rhscl-automation

mongodb container is not maintained any more in this org. closing.

hhorak avatar Apr 10 '24 11:04 hhorak