pyhf icon indicating copy to clipboard operation
pyhf copied to clipboard

refactor: Revise impact plot visualization

Open matthewfeickert opened this issue 5 years ago • 3 comments

Description

Resolves #822

Checklist Before Requesting Reviewer

  • [ ] Tests are passing
  • [ ] "WIP" removed from the title of the pull request
  • [x] Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • [x] Summarize commit messages into a comprehensive review of the PR
* Fix bug in impact plot visualization
* Improve structure of the noteboo

matthewfeickert avatar May 29 '20 22:05 matthewfeickert

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@kratsg This is currently just in a debugging state, hence all the extra junk in the notebook.

matthewfeickert avatar May 29 '20 22:05 matthewfeickert

Codecov Report

Merging #883 (af1ec6a) into master (2b0a1e2) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #883   +/-   ##
=======================================
  Coverage   96.28%   96.28%           
=======================================
  Files          56       56           
  Lines        3179     3179           
  Branches      438      438           
=======================================
  Hits         3061     3061           
  Misses         75       75           
  Partials       43       43           
Flag Coverage Δ
unittests 96.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b0a1e2...af1ec6a. Read the comment docs.

codecov[bot] avatar May 29 '20 22:05 codecov[bot]