Pull Request Description

See #1284.

Checklist Before Requesting Reviewer

• [ ] Tests are passing
• [ ] "WIP" removed from the title of the pull request
• [ ] Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

• [ ] Summarize commit messages into a comprehensive review of the PR

Codecov Report

Merging #1940 (1f66041) into master (f01dcf5) will decrease coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1940      +/-   ##
==========================================
- Coverage   98.26%   98.24%   -0.03%     
==========================================
  Files          69       68       -1     
  Lines        4443     4380      -63     
  Branches      748      728      -20     
==========================================
- Hits         4366     4303      -63     
  Misses         45       45              
  Partials       32       32              

Flag	Coverage Δ
contrib	26.55% <68.67%> (+0.51%)	:arrow_up:
doctest	60.54% <97.59%> (-0.52%)	:arrow_down:
unittests-3.10	96.14% <100.00%> (-0.01%)	:arrow_down:
unittests-3.7	96.12% <100.00%> (-0.01%)	:arrow_down:
unittests-3.8	96.16% <100.00%> (-0.01%)	:arrow_down:
unittests-3.9	96.18% <100.00%> (-0.01%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/pyhf/readxml.py	96.37% <ø> (ø)
src/pyhf/tensor/numpy_backend.py	98.58% <100.00%> (+0.06%)	:arrow_up:
src/pyhf/typing.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

This adds back in #1937.

Henry we're going to merge this, but if later you find something that you think we should revise please let us know!