pyhf icon indicating copy to clipboard operation
pyhf copied to clipboard

Should pyhf detect and handle multiple modifiers with the same type/name?

Open kratsg opened this issue 3 years ago • 1 comments

Summary

Unlike correlating modifiers (e.g. histosys and normsys) - when we have modifiers of a given type (e.g. normsys) with the same name added to a particular sample, only the last one is being picked up and used in the model with no warning from pyhf. Should we catch this?

Related: #1830.

Additional Information

No response

Code of Conduct

  • [X] I agree to follow the Code of Conduct

kratsg avatar Jun 28 '22 15:06 kratsg

Oh yeah that seems like a bug if we aren't very loudly warning. I would be +1 on adding this.

matthewfeickert avatar Jun 28 '22 16:06 matthewfeickert