Description

Please first read CONTRIBUTING.md.

Please describe the purpose of this pull request in some detail. Reference and link to any relevant issues or pull requests.

Checklist Before Requesting Reviewer

• [ ] Tests are passing
• [ ] "WIP" removed from the title of the pull request
• [ ] Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

• [ ] Summarize commit messages into a comprehensive review of the PR

Codecov Report

Merging #1688 (28c60c7) into master (82bd0f7) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1688   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files          69       69           
  Lines        4439     4439           
  Branches      748      748           
=======================================
  Hits         4362     4362           
  Misses         45       45           
  Partials       32       32           

Flag	Coverage Δ
contrib	25.81% <ø> (ø)
doctest	61.02% <ø> (ø)
unittests-3.10	96.14% <ø> (ø)
unittests-3.7	96.13% <ø> (ø)
unittests-3.8	96.17% <ø> (ø)
unittests-3.9	96.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

I might end up putting this on my github and hosting a JSON file that updates nightly instead... that might be better than putting it in pyhf.

I might end up putting this on my github and hosting a JSON file that updates nightly instead... that might be better than putting it in pyhf.

Yeah, I can understand the idea of wanting to have this be something that is outside of the main repo so that maintenance of it isn't tied to the rest of the project. @kratsg any objection to placing it under the pyhf GitHub org? https://www.github.com/pyhf/

Yeah, I can understand the idea of wanting to have this be something that is outside of the main repo so that maintenance of it isn't tied to the rest of the project. @kratsg any objection to placing it under the pyhf GitHub org? https://www.github.com/pyhf/

I'll migrate it tonight. Is it set up to run nightly already? Can you make that change, then I'll migrate over?

I'll migrate it tonight. Is it set up to run nightly already? Can you make that change, then I'll migrate over?

This workflow you just wrote? If so, then yes given

  schedule:
  - cron:  '1 0 * * *'
  workflow_dispatch:

if not then I'm not sure what you're referring to, sorry.

Closing this (and deleting branch) in favor of https://github.com/pyhf/public-probability-models

Closing this (and deleting branch) in favor of https://github.com/pyhf/public-probability-models

Thanks @kratsg!