pyhf icon indicating copy to clipboard operation
pyhf copied to clipboard

Published 20 hours ago • verified publisher icon scikit-hep

build: Use Typer for CLI

Open matthewfeickert opened this issue 4 years ago • 2 comments

Description

Resolves #1674

Use Typer to provide the CLI API

Checklist Before Requesting Reviewer

  • [ ] Tests are passing
  • [ ] "WIP" removed from the title of the pull request
  • [ ] Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • [ ] Summarize commit messages into a comprehensive review of the PR
* Set Typer as an install requirement, replacing Click
* Drop click_completion and 'shellcomplete' extra
   - Typer provides an option to generate shell completions
* ...

matthewfeickert avatar Oct 28 '21 08:10 matthewfeickert

FYI, typer is completely broken due to click 8.1, see https://github.com/pallets/click/issues/2226 or the typer issue.

henryiii avatar Mar 30 '22 16:03 henryiii

FYI, typer is completely broken due to click 8.1, see pallets/click#2226 or the typer issue.

Yeah I think this PR is going to be in stasis for quite some time (even before you pointed this out), but I didn't want to close it yet.

matthewfeickert avatar Mar 30 '22 16:03 matthewfeickert