yahoo-finance-api

yahoo-finance-api copied to clipboard

Description Adding stock Summary to get information about shares and stock data I need this information to get the float shares of a stock If I need this information maybe another one needs it

Hi, could you please explain why this is needed. Isn't getQuote doing the same thing?

Hi @scheb thank you for your quick response, getQuote don't have some important information (in my case is critical to get the float shares, operatingCashflow, sharesShortPriorMonth, freeCashflow, etc).

I have 2 options,

1. Create a new method (stockSummary)
2. Add what I need to getQuote method.

Because was easier to tests and less disruptive to the current method, I had pick option 1

Let me know what do you think about it.

Here are the data for AAPL called by each method stockSummary.json => https://gist.github.com/elminson/e996c7bbcd21c066406b651bb061775f

getQuote.json => https://gist.github.com/elminson/0d1e2afaba3b815de5cc06cc1fc1813c

Okay, I see. Could you please do me a favor and rebase your changes onto the main branch and force-push an update? For some reason the CI didn't trigger. I hope it will after the push. I'm pretty sure there will be some code style issues popping up that we'd need to fix before we can merge.

@scheb I think now should be good if not let me know

Please check the coding standards job, there have been some issues popping up.

@scheb all code standards now are passing on my local please confirm :)

Welcome to Codecov :tada:

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

fixing the failing standards @scheb my PHP standard is set to use tabs :) fixed

Merged and tagged as v4.9.0