Christian Scheb

Results 45 comments of Christian Scheb

> We cannot remove them as these classes are not marked as internal. We need to deprecate these constructor parameters first (happy to help with the BC layer.) @chalasr Ok,...

So here's a suggestion. The fabbot.io failing seems to be unrelated to my changes. Considerations: - The fact that `$listeners` is an iterable makes things messy when trying to ensure...

This is where the provider preparation is executed and where a fallback logic would need to go: https://github.com/scheb/2fa/blob/43051f8e5eb54fc5c69fa3569636a42225cad6a6/src/bundle/Security/TwoFactor/Provider/TwoFactorProviderPreparationListener.php#L114

We cannot change this line, because it changes the behavior of the bundle. If we change this, you're no longer redirected to the 2fa form after login. I tried locally...

Closing this as "won't fix", since it's necessary to fetch the security token, to determine if we're in a 2fa process or not. The recommended solution is to flag routes...