Steve Calvert

icon indicating a website link https://github.com/scalvert icon indicating an email [email protected]

icon company @linkedin icon location Pleasanton, CA icon location Software Engineer @ glean

Results 95 comments of Steve Calvert

Change Request: Introduce a system to suppress existing errors

@nzakas no problem! Is there an RFC template I should use?

Failing test case for lazily loaded engines with loading states

@rwjblue any idea why that job is failing? I tried to parse the logs but they're making my eyes bleed...

Implement meta objects for rules

@mansona this is a great start! A few questions that I'm hoping we can answer: 1. I assume we're not intending on outputting the meta in JSON results. Can you...

Add ability to detect files not included in the config

I think we could narrow what we're detecting to .js and .css, as those are the types that we're actually concerned about. It would be fairly simple to cross reference...

[WIP] Preserve queryParams

Is it worth investigating this with the new [public `router` service](https://github.com/emberjs/ember.js/blob/master/packages/ember-routing/lib/services/router.js)?

Parallel compilations appears to troll hash-for-dep cache

Specifically, the issue appears to be localized to the changes in babel-plugin-htmlbars-inline-precompile. Looking at the diff in [v1.0.2 to v1.0.3](https://github.com/ember-cli/ember-cli-htmlbars-inline-precompile/compare/v1.0.2...v1.0.3), you can see that one of the dependency bumps includes...

Minimize the production impact

We could likely strip out the code in a prod build. Would this work?

Upgrade `registerHook` and `runHooks` as official public APIs

Thanks, @drewlee! Much appreciated!

Test isolation validation should include canceling active test waiters in ember-test-watiers

Had a good chat with @rwjblue offline. We agreed that adding this API will likely result in leaks actually occurring, defeating the point of the waiters. We discussed evaluating `settled`...

Track and cancel all scheduled tasks on destruction

Let me throw you a [lifeline](https://github.com/ember-lifeline/ember-lifeline)!