Seth Bromberger comments

Results 270 comments of


                                            Seth Bromberger

Modularity for bipartite graphs

I'm not aware of any efforts to implement new modularity functions, but I'll leave this open in case there's interest.

fix induced_subgraph indexing with vector of Bools

Sorry - what's the specific problem here?

fix induced_subgraph indexing with vector of Bools

It seems as if you're trying to use a bitvec / vector of boolean where `true` values indicate inclusion in the induced subgraph. That's not (currently) how it works: the...

Proposal: Relax restriction on vertex IDs

I think that at this point you'd probably be better off reviving Graphs.jl. It did all of this. I'm pretty sure consecutive one-based vertices are assumed in a few core...

A proposal of an all_simple_paths function implementation

> I think that as long as we are iterating over the paths and not realizing them all in memory, it is a fine addition. I draw that distinction because...

Reduced time & memory footprint for Tarjans algorithm, fixed a bug where it was O(E^2) on star graphs.

I am very ok with this as long as it passes @simonschoelly 's muster. Thank you.

Reduced time & memory footprint for Tarjans algorithm, fixed a bug where it was O(E^2) on star graphs.

Hi all, Thanks for the PR and for the comprehensive review! I'm tracking - let me know when it's ready for a final review and merge.

Reduced time & memory footprint for Tarjans algorithm, fixed a bug where it was O(E^2) on star graphs.

Hi all, Just wanted to ping on this. Is it ready for final review?

Inconsistency about weights

OK, let's see if this helps clear things up: `SimpleGraph`s are unweighted. That is, each edge has a unit weight of 1. You. cannot change this - it is a...

Ah, you're talking about `SimpleWeightedGraph`s. The reason `adjacency_matrix` returns the weights there is twofold: 1) it's super efficient. 2) it's probably incorrect. That is, we really should be doing a...