Sam Clegg

Results 826 comments of Sam Clegg

I see. In that case we can probably simply remove the option to disable mutable globals.

Perhaps `--enable-X.X` and `--disable-all` are both useful.

[main.zip](https://github.com/WebAssembly/binaryen/files/8606495/main.zip)

Seems like this is due to memory segments that are not loaded at specific contant offsets, but based off of `__memory_base`. I'll disable + dyanmic linking tests for now which...

Yes I think that solution makes sense. In the short term I've disabled MEMORY64 + dynamic linking. Once everything else is working I'll re-enable that try that fix.

[test_stack_placement.zip](https://github.com/WebAssembly/binaryen/files/9012458/test_stack_placement.zip) Attached is a copy of the failing input wasm.

Looks like the proximate fix is to not assume that segments have const offsets.

I think we already import __table_base32 .. so I guess we should create new import called `__memory_base32`?

I think this pass has to create the new import and then it will be up to emscripten to provide it... trying to remember how to write binaryen code now...