Ian Clarke

Results 187 comments of Ian Clarke

That sounds great, let me know once you'd like some feedback. On Mon, Oct 21, 2013 at 12:31 PM, Jack Singleton [email protected]: > Once I've added a few more test...

@jacksingleton just wanted to check in and see if you've had a chance to make any progress on this? If not, I might try to take a whack at it...

TrPeerManager. maintenance() will spawn new assimilation attempts if peers.size() < minPeers, is something additional required?

ok, i see, the suggestion is we should do several. Let's see how well the current code works in practice first.

I think we need to add a unique identifier as a parameter to requestNewConnection() which is forwarded through the chain - such that if we see the same one twice...

A few notes: The unique identifier will be unique _to a particular assimilation request chain_ - so we create it randomly in the first short AssimilateSessionImpl.startAssimilation() method (the one called...

@nomel7 Yes, I think that's a good idea. What do you think @ravisvi ?

1. a new random UID is created in requestNewConnection(final RSAPublicKey requestorPubkey) method 2. This UID is passed as a second parameter to the requestNewConnection(final RemoteNodeAddress joinerAddress) method 3. At the...

@ravisvi Is this issue ready to be closed?