Athena icon indicating copy to clipboard operation
Athena copied to clipboard

Use a proper logging framework

Open sanity opened this issue 15 years ago • 6 comments

Right now the only logging is through a primitive and ugly static final boolean StoreIterator.verbose. We should use proper logging (provided it doesn't slow anything down).

sanity avatar Jun 23 '10 19:06 sanity

What do we need to log?

Are you talking about setting up a way to write the DB to file? If so, surely an append-only filesystem would be easiest to implement and best in terms of concurrency?

KushalP avatar Jun 23 '10 19:06 KushalP

No, I just mean a logging framework, like log4j or something - for debugging purposes.

sanity avatar Jun 23 '10 19:06 sanity

Ah, okay. I'll set up the dependency for it now.

KushalP avatar Jun 23 '10 19:06 KushalP

Is log4j the best option? I've never found a Java logging framework I liked, they all seem over-complicated.

Anyway, I guess we can go with whatever option you prefer.

sanity avatar Jun 23 '10 19:06 sanity

These are our options, and two of them use log4j: http://en.wikipedia.org/wiki/Java_logging_framework#Comparison_of_features

KushalP avatar Jun 23 '10 19:06 KushalP

Ok, log4j sounds good

sanity avatar Jun 23 '10 19:06 sanity