sandstorm icon indicating copy to clipboard operation
sandstorm copied to clipboard

Allow multiple values for HTTPS_PORT

Open zenhack opened this issue 3 years ago • 7 comments

Fixes #3619


@ocdtrekkie, feel like testing? I have verified it doesn't break my box, but haven't actually tried adding a second port, mainly because I'd have to set up port forwarding and it's late enough that I'm wanting to put this down for the night.

zenhack avatar May 20 '22 04:05 zenhack

I will definitely test this weekend (partially because if this works I do not want to wait for a release). Running a server backup now, which I always do before updating to experimental code.

ocdtrekkie avatar May 20 '22 06:05 ocdtrekkie

Okay, so, we are close, because Sandstorm is definitely listening on the port! However, it looks like that host name recognition behavior may look at ports, because I get this (I have 443 as an HTTPS alternate port for now):

image

ocdtrekkie avatar May 20 '22 19:05 ocdtrekkie

Interesting. And this doesn't happen with an extra port added to PORT?

I will have to actually test this myself soonish.

zenhack avatar May 20 '22 20:05 zenhack

I don't have any HTTP ports exposed to the outside world, so I don't know, to be honest. I'd probably go for setting up a VM to play with it if I want to start opening those.

What I did test (because I was getting the unrecognized hostname on my alternate port) was trying to set up a static web publishing on the alternate port, and that also did not work.

ocdtrekkie avatar May 20 '22 21:05 ocdtrekkie

Good catch. Just pushed an attempt to fix this; give it a try when the build finishes.

zenhack avatar May 21 '22 04:05 zenhack

This definitely worked for the main URL, but it appears to not work for anything else.

https://ocdhost.sandcats.io/shared/X8HYTaml-nrKIHORyo-C9AwuCzZ0FUoT_-OEXHUw10f even has the same exact hostname, as the main URL, but it gives the unrecognized hostname error. Web publishing didn't work either.

ocdtrekkie avatar May 21 '22 13:05 ocdtrekkie

Ok. I'm going to mark this as a draft for now; at some point I'll set up port forwarding myself and mess with it so we can do fewer round trips.

zenhack avatar May 21 '22 17:05 zenhack