sandstorm

sandstorm copied to clipboard

This fixes #3239 by providing a config option to re-enable the ability to upgrade demo accounts to full accounts, which was removed in order to allow alpha to act as the demo server when oasis was shut down.

Unfortunately, this seems to break other tests. The handful I examined resulted in permission errors trying to upload the test app; presumably when this is enabled our test accounts are somehow getting marked as not allowed to upload their own apps.

---

Accordingly, I'm marking this as a draft until that can be debugged.

(Note that this includes the commits from #3609, since those are necessary for any of the tests to pass).

Does ALLOW_UNINVITED permit users who sign in without an invite to create grains? I am not sure if the config option is self-explanatory enough. How does this interact with the permission to allow demo accounts, and what happens if one but not the other is set?

...Which is to say, I maybe might suggest a better config variable name, and definitely would like to see the docs updated in the PR.

Yeah, I should definitely update the docs before this is merged, and I just copied the name from the meteor setting, so could probably be improved.