sandstorm

sandstorm copied to clipboard

Important that we don't lose these, so making tracking issues, so we can get the tests running clean again. <kentonv> Also broken, but my fault: tests/account because I removed the ability to upgrade demo accounts,

I tried just patching out the bit at the beginning that upgrades a demo account, and instead logs in to a fresh dev account:

diff --git a/tests/tests/account.js b/tests/tests/account.js
index 538221d5..109bf240 100644
--- a/tests/tests/account.js
+++ b/tests/tests/account.js
@@ -37,21 +37,15 @@ module.exports["Test link credentials"] = function (browser) {
   browser
     .init()
 
-    // Upgrade a demo account to a real account by linking an credential.
-    .url(browser.launch_url + "/demo")
-    .disableGuidedTour()
-    .waitForElementVisible(".demo-startup-modal .start", medium_wait)
-    .click(".demo-startup-modal .start")
-    .disableGuidedTour()
-    .waitForElementPresent(".main-content>.app-list", medium_wait)
-    .click(".login>button.show-popup")
+    // Sign up with a new dev account.
+    .url(browser.launch_url)
     .waitForElementVisible(".login-buttons-list", short_wait)
     .click(".login-buttons-list button.dev")
     .waitForElementVisible("input[name=name]", short_wait)
     .setValue("input[name=name]", devName1)
     .submitForm(".login-buttons-list form.dev")
     .waitForElementVisible("form.account-profile-editor", short_wait) // confirm profile
-    // Profile defaulted to new credential's name, not "Demo User".
+    // Profile defaulted to new credential's name.
     .assert.attributeContains("form.account-profile-editor input[name=nameInput]", "value", devName1)
     .submitForm("form.account-profile-editor")
     .execute(function () { return Meteor.user().profile.identicon; }, [], function (response) {

But, in this case the error message re: linking an in-use credential to another account never appears -- it goes through. Experimenting manually shows that this only fails for dev accounts entered in the "custom" box; if you try to log in as dave and then link alice it fails.