watchfiles icon indicating copy to clipboard operation
watchfiles copied to clipboard

Please make a new release using pyo3 0.20.3

Open mgorny opened this issue 1 year ago • 7 comments

Description

The current PyO3 version of 0.20.0 is broken on PowerPC (https://github.com/PyO3/pyo3/commit/9d1b11f70459367593e4cb92919f5f98c156dda9). This is preventing PowerPC users from installing watchfiles cleanly.

Could you update PyO3 and make a new release, please?

Example Code

No response

Watchfiles Output

No response

Operating System & Architecture

Linux-6.1.60-gentoo-dist-hardened-ppc-POWER9_-architected-,_altivec_supported-with-glibc2.38 #1 SMP Fri Dec 1 22:10:49 UTC 2023

Environment

No response

Python & Watchfiles Version

n/a (not installable)

Rust & Cargo Version

cargo 1.74.1 (ecb9851af 2023-10-18); rustc 1.74.1 (a28077b28 2023-12-04)

mgorny avatar Feb 24 '24 14:02 mgorny

@mgorny Isn't this fixed by https://github.com/samuelcolvin/watchfiles/releases/tag/v0.21.0 ?

gaby avatar May 04 '24 13:05 gaby

Nope. Cargo.lock says 0.20.0.

mgorny avatar May 04 '24 14:05 mgorny

@samuelcolvin Any chance to get a new release with update dependencies. PyO3 is already on v0.21.x

Probably worth adding dependabot.yml to the repo.

gaby avatar May 04 '24 20:05 gaby

PR welcome, otherwise I'll try soon.

samuelcolvin avatar May 04 '24 21:05 samuelcolvin

I was going to update them, then realize PyO3 v0.21.x changed the API and I dont know Rust 😂

I cam submit one for dependabot config

gaby avatar May 04 '24 21:05 gaby

All updates are complete, watchfiles now uses latest pyo3, and i've updated actions version.

@gaby and @mgorny please try the latest version from main and confirm you're happy, then I'll do a release.

samuelcolvin avatar May 06 '24 10:05 samuelcolvin

Yeah, I can confirm main now builds on PowerPC and has no PPC-specific test regressions. However, it is still affected by #254. But I'm happy to just skip that test, if need be.

mgorny avatar May 08 '24 08:05 mgorny

v0.22.0 is released.

samuelcolvin avatar May 27 '24 12:05 samuelcolvin

@samuelcolvin Thank you!

gaby avatar May 27 '24 12:05 gaby