dirty-equals

dirty-equals copied to clipboard

Since float('nan') != float('nan') we need a custom FloatNan type.

inf/-inf too?

Hi @samuelcolvin, if there is still interest in this issue I can take it! Any drawback in using math.isnan and math.isinf for the checks?

definitely still interest, no drawback I know of to math.isnan.

I guess we have FloatNan, FloatInfPos, FloatInfNeg?

I would consider a more general FloatInf as well (that's the use case it brought me here in the first place).

Just to make sure on naming convention, they should all have a Is prefix, correct?

Sorry, yes Is prefix.

FloatInf is fine by me.

This is done, yes?