Samuel Colvin
Samuel Colvin
I think it looks great. Not many stars, but that doesn't matter much necessarily. The first two things to check are: 1. Good much do the binaries increase in size....
equality. > I may be confused but, why `set` and `frozenset`? Those collections doesn't allow for duplicate values. Well, the question is whether `[1, 2, 2, 3]` as input to...
Great, thank you.
this needs to be in rust since the list validator is all written in rust, see https://github.com/pydantic/pydantic-core/blob/9e54f7833a0d88daf9696430756007f0f7f8dc0c/src/validators/list.rs#L96
Closing, if someone really wants this built into pydantic-core, we would of course be willing to review a PR. BTW, https://github.com/pydantic/pydantic-core/pull/820#issuecomment-1670475909 won't work in the case of inputs which are...
Let's defer this, I'm not sure it's necessary.
I haven't used it, but it looks great. At the very least, it's more validation that the typescript world needs validation. If we could get tydantic to work... 👀.
Correct. I think you might be right about strict mode on this context, even with something as apparently obvious as "strict mode" there are edge cases where we do do...
I think we're in agreement on both, just need to work out if it's going to cause ugly edge cases with union validation.
I don't care about the python interface yet, let's work out how it should work in rust first. I guess this should be added to [`TypedDictValidator`](https://github.com/pydantic/pydantic-core/blob/bcf799f0e8caa9774e839a2d8d30c7f4dd15852f/src/validators/typed_dict.rs#L32). I think the best...