Thomas Gazagnaire

Results 226 comments of Thomas Gazagnaire

Modulo my comments above, this is ready to be merged - the current API subsumes the low-level HTTP API (which should be faster and more reliable). So I plan to...

No strong opinion - but it's an error that I have seen many beginners hit, and the error message is not helpful. We should at least define what is allowed...

I've reverted these changes here: https://github.com/ocaml/opam-repository/pull/25609 The goal is to give us more time to find the appropriate fix and unbreak downstream Windows users.

@MSoegtropIMC is the Coq platform still broken? I thought I completely reverted this PR with #25609 , but maybe I forgot something (if yes, it was my mistake -- as...

this seems to be missing a `depext`?

@Khady could you have a look at the linking issue? ``` # Fatal error: exception Dl.DL_error("./unit.exe: undefined symbol: argon2_type2string") ``` Is this expected?

I'm merging the PR anyway as it seems to fix user issues (from @MarcCoquand report). But feel free to investigate why one reverse dependency is broken :-)

@FantomeBeignet ping - could you update your patch to consider the review above? Or do you need help to do so?

I also agree that the opam-repository is not the right place to host a 4k diff against an upstream package. Creating a fork and a new release from that fork...

Could you also add a `.travis.yml`? (such as the one in https://github.com/ocaml/ocaml-ci-scripts) Thanks!