salt icon indicating copy to clipboard operation
salt copied to clipboard

Published 20 hours ago • verified publisher icon saltstack

3006.x: logging regression: fix loglines/findCaller introspection

Open mattp- opened this issue 5 months ago • 0 comments
trafficstars

What does this PR do?

python 3.8 changed the way it was inferring loglines from the callstack; the stacklevel was exposed as a way around this to tell logging to ignore an arbitrary level of frames ontop of the 1 it knows about.

I tried writing a test but for whatever reason caplog / salt-test-factories doesn't exhibit the same behavior as directly running via CLI. this should be easily reproducible though.

this PR ports https://github.com/saltstack/salt/pull/68042 to 3006.x

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

  • [ ] Docs
  • [ x] Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
  • [ ] Tests written/updated

Commits signed with GPG?

Yes

mattp- avatar Jun 06 '25 20:06 mattp-